Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to parcel v2 and node 14 support #397

Merged
merged 13 commits into from
May 26, 2021
Merged

Upgrade to parcel v2 and node 14 support #397

merged 13 commits into from
May 26, 2021

Conversation

Himavanth
Copy link
Contributor

@Himavanth Himavanth commented Apr 19, 2021 •
edited
Loading

Description

This is a breaking change.
For old apps with our default react UI, "plugins": ["@babel/plugin-transform-react-jsx"] should be added to.babelrc file.
Also, need to npm install @babel/plugin-transform-react-jsx.

Todo

Related Issue

Motivation and Context

How Has This Been Tested?

<style> </style>
Test eveything   Node12 - existing Node12 - New Node14 - existing Node14 - New
kind: nodejs:12        
React UI          
aio app deploy   DONE DONE DONE DONE
exc shell   DONE DONE DONE DONE
aio app run   DONE DONE DONE DONE
debug UI and actions   DONE DONE DONE DONE
aio app run --local   DONE DONE DONE DONE
debug UI and actions   DONE DONE DONE DONE
Raw UI          
aio app deploy   DONE DONE DONE DONE
exc shell   DONE DONE DONE DONE
aio app run   DONE DONE DONE DONE
debug UI and actions   DONE DONE DONE DONE
aio app run --local   DONE DONE DONE DONE
debug UI and actions   DONE DONE DONE DONE
           
kind: nodejs:14        
React UI          
aio app deploy   DONE DONE DONE DONE
exc shell   DONE DONE DONE DONE
aio app run   DONE DONE DONE DONE
debug UI and actions   DONE DONE DONE DONE
aio app run --local   DONE DONE DONE DONE
debug UI and actions   DONE DONE DONE DONE
Raw UI          
aio app deploy   DONE DONE DONE DONE
exc shell   DONE DONE DONE DONE
aio app run   DONE DONE DONE DONE
debug UI and actions   DONE DONE DONE DONE
aio app run --local   DONE DONE DONE DONE
debug UI and actions   DONE DONE DONE DONE

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 23, 2021 •
edited
Loading

Codecov Report

Merging #397 (325c0c9) into master (994dbd0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #397   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1695      1691    -4     
  Branches       284       285    +1     
=========================================
- Hits          1695      1691    -4
Impacted Files Coverage Δ
src/commands/app/build.js 100.00% <100.00%> (ø)
src/commands/app/run.js 100.00% <100.00%> (ø)
src/lib/bundle-serve.js 100.00% <100.00%> (ø)
src/lib/run-dev.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 994dbd0...325c0c9. Read the comment docs.

@Himavanth Himavanth marked this pull request as ready for review May 5, 2021 09:19
@moritzraho
Copy link
Member

moritzraho commented May 6, 2021 •
edited
Loading

linked this PR to
adobe/generator-aio-app#139
and adobe/aio-lib-web#150

Then ran a first e2e test using node 12 (which still should be supported):

> aio app init
<selected react spectrum UI>
> aio app run --skip-actions
✖ serving front-end using bundler serve...
<KEEPS STUCK need to ctrl+c>

Anyone else can reproduce ?

EDIT more test data:

  • same error for run with the Pure HTML/JS template
  • deploy works great tho for both templates !

@Himavanth
Copy link
Contributor Author

Yeah i can reproduce this. I see linking issues. This should work fine in a normal install but i am trying to fix this for testing.

@moritzraho
Copy link
Member

Tested again with new changes, run works for both UIs, and is super fast, great work!
Lgtm!

@Himavanth Himavanth changed the title Initial commit for parcel v2 support Upgrade to parcel v2 and node 14 support May 25, 2021
@Himavanth Himavanth merged commit 66a7a10 into master May 26, 2021
@Himavanth Himavanth deleted the parcelv2 branch July 12, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzraho moritzraho moritzraho approved these changes

@shazron shazron Awaiting requested review from shazron

@sandeep-paliwal sandeep-paliwal Awaiting requested review from sandeep-paliwal

@purplecabbage purplecabbage Awaiting requested review from purplecabbage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Himavanth @moritzraho